Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flexure diagnostic code to class methods #1845

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

kbwestfall
Copy link
Collaborator

As titled. This is directed into order_sync, #1835, because of a number of other doc fixes that I added to that branch.

This deals with a circular import that I was getting when compiling the docs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.52174% with 43 lines in your changes missing coverage. Please review.

Project coverage is 38.13%. Comparing base (01aed2e) to head (449d5de).

Files with missing lines Patch % Lines
pypeit/spec2dobj.py 5.26% 18 Missing ⚠️
pypeit/specobjs.py 7.14% 13 Missing ⚠️
pypeit/scripts/chk_flexure.py 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           order_sync    #1845      +/-   ##
==============================================
- Coverage       38.13%   38.13%   -0.01%     
==============================================
  Files             209      209              
  Lines           48597    48598       +1     
==============================================
  Hits            18531    18531              
- Misses          30066    30067       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this and sorry for giving you more work!
I fixed a couple of things. All good to be merged.

Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx thx

@kbwestfall kbwestfall merged commit 417c50b into order_sync Aug 29, 2024
23 checks passed
@kbwestfall kbwestfall deleted the flexure_diag branch August 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants